[PATCH v2] drm/nouveau/gr: mark gm107_grctx_generate_tpcid() static

[Baoyou Xie]

dear all:
    I have resend a patch, which consolidate the 'nouveau' changes into it,
its subject is "drm/nouveau: silence warnings reported during builds with
W=1".
   FYI.

On 30 August 2016 at 20:40, Arnd Bergmann <arnd at arndb.de> wrote:

> On Tuesday 30 August 2016, Baoyou Xie wrote:
> > On 30 August 2016 at 00:01, Sean Paul <seanpaul at google.com> wrote:
> >
> > > On Mon, Aug 29, 2016 at 9:02 AM, Baoyou Xie <baoyou.xie at linaro.org>
> wrote:
> > > > We get 1 warning when build kernel with W=1:
> > > > drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c:937:1: warning: no
> > > previous prototype for 'gm107_grctx_generate_tpcid'
> [-Wmissing-prototypes]
> > > >
> > > > In fact, this function is only used in the file in which it is
> > > > declared and don't need a declaration, but can be made static.
> > > > so this patch marks this function with 'static'.
> > > >
> > >
> > > It would make things a lot easier if you either consolidated all of
> > > these static changes into one patch, or released them as a series.
> > >
> > >
> > Do you mean that I need to consolidate all of them into one patch this
> > time? or next time?
>
> I'd suggest consolidating the 'nouveau' changes into a single patch,
> as this is one (very big) driver and resend that one.
>
>         Arnd
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20160831/2a3390ab/attachment-0001.html>