[PATCH v2 2/3] drm/edid: Implement SCDC support detection
Ville Syrjälä
ville.syrjala at linux.intel.com
Mon Dec 5 13:35:32 UTC 2016
On Mon, Dec 05, 2016 at 12:11:46PM +0100, Thierry Reding wrote:
> On Mon, Dec 05, 2016 at 09:16:27AM +0100, Daniel Vetter wrote:
> > On Mon, Dec 05, 2016 at 08:57:43AM +0100, Thierry Reding wrote:
> > > On Sat, Dec 03, 2016 at 04:35:24AM +0000, Sharma, Shashank wrote:
> > > > Hi Thierry,
> > > >
> > > > If you can please have a look on this patch, I had written one to parse HF-VSDB, which was covering SCDC detection too.
> > > > https://patchwork.kernel.org/patch/9452259/
> > >
> > > I think there had been pushback before about caching capabilities from
> > > EDID, so from that point of view my patch is more inline with existing
> > > EDID parsing API.
> >
> > Hm, where was that pushback? We do have a bit a mess between explicitly
> > parsing stuff (e.g. eld) and stuffing parsed data into drm_display_info.
>
> You did object to a very similar patch some time ago that did a similar
> thing for DPCD stuff. And also Villa had commented on an earlier patch
> from Jose about concerns of bloating core structures:
>
> https://patchwork.freedesktop.org/patch/104806/
Yeah, the same old "adding stuff all over without actual users" story.
It's near impossible to judge whether the added things are actually
useful (or if the implementation is the best) without seeing how it's
going to be used.
--
Ville Syrjälä
Intel OTC
More information about the dri-devel
mailing list