[PATCH v3 1/2] dt-bindings: drm/bridge: adv7511: Add regulator bindings

Laurent Pinchart laurent.pinchart at ideasonboard.com
Tue Dec 6 12:46:55 UTC 2016


Hi Mark,

On Tuesday 06 Dec 2016 10:05:17 Mark Brown wrote:
> On Mon, Dec 05, 2016 at 11:16:22PM +0200, Laurent Pinchart wrote:
> > On Monday 05 Dec 2016 13:11:51 Bjorn Andersson wrote:
> >> Further more, a DT binding for a particular block should describe that
> >> block; so if we have three different 1.8V pins then the DT binding
> >> should reflect this - even if our current platform have them wired to
> >> the same regulator.
> > 
> > This has been discussed previously, and Rob agreed that if the datasheet
> > recommends to power all supplies from the same regulator we can take that
> > as a good hint that a single supply should be enough. In the very
> > unlikely event that a board would require control of more regulators we
> > can always extend the DT bindings later without breaking backward
> > compatibility.
> 
> No, don't do this - introducing special snowflake bindings just makes
> things more complex at the system level and tells everyone else that
> they too can have special snowflake bindings.  Someone should be able to
> connect up the regulators based purely on a schematic.  Just describe
> the hardware, it's just one extra line in the DT per regulator.

There are power supply pin that have different names but documented as having 
to be connected to the same supply. I really see no point in having multiple 
regulators for them.

-- 
Regards,

Laurent Pinchart



More information about the dri-devel mailing list