[PATCH] drm/irq: drm_legacy_ prefix for legacy ioctls

Daniel Vetter daniel at ffwll.ch
Wed Dec 7 10:26:06 UTC 2016


On Wed, Dec 07, 2016 at 11:28:54AM +0200, Jani Nikula wrote:
> On Wed, 07 Dec 2016, Daniel Vetter <daniel.vetter at ffwll.ch> wrote:
> > Spotted while auditing our ioctl table. Also nuke the
> > not-really-kerneldoc comments, we don't document internals and
> > definitely don't want to mislead people with the old dragons.
> 
> Not just specific to this patch, but I'm not sure I agree with the "we
> don't document internals" in general. That seems to be something that
> just started happening without much discussion. We have *loads* of
> complicated functions that would benefit from documentation, even if
> they're internal (i.e. not exported).

I do keep the comments if I think they're useful, but kernel-doc for them
seems serious overkill. In this case here I couldn't really justify even
just the comment for myself, but maybe I just want to hide those old
dragons too much ;-)
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch


More information about the dri-devel mailing list