[PATCH] linux/types.h: enable endian checks for all sparse builds
Michael S. Tsirkin
mst at redhat.com
Thu Dec 8 02:29:39 UTC 2016
By now, linux is mostly endian-clean. Enabling endian-ness
checks for everyone produces about 200 new sparse warnings for me -
less than 10% over the 2000 sparse warnings already there.
Not a big deal, OTOH enabling this helps people notice
they are introducing new bugs.
So let's just drop __CHECK_ENDIAN__. Follow-up patches
can drop distinction between __bitwise and __bitwise__.
Cc: Linus Torvalds <torvalds at linux-foundation.org>
Suggested-by: Christoph Hellwig <hch at infradead.org>
Signed-off-by: Michael S. Tsirkin <mst at redhat.com>
---
Linus, could you ack this for upstream? If yes I'll
merge through my tree as a replacement for enabling
this just for virtio.
include/uapi/linux/types.h | 4 ----
1 file changed, 4 deletions(-)
diff --git a/include/uapi/linux/types.h b/include/uapi/linux/types.h
index acf0979..41e5914 100644
--- a/include/uapi/linux/types.h
+++ b/include/uapi/linux/types.h
@@ -23,11 +23,7 @@
#else
#define __bitwise__
#endif
-#ifdef __CHECK_ENDIAN__
#define __bitwise __bitwise__
-#else
-#define __bitwise
-#endif
typedef __u16 __bitwise __le16;
typedef __u16 __bitwise __be16;
--
MST
More information about the dri-devel
mailing list