[PATCH 1/4] drm: Protect master->unique with dev->master_mutex

Chris Wilson chris at chris-wilson.co.uk
Mon Dec 12 09:39:55 UTC 2016


On Sat, Dec 10, 2016 at 10:52:52PM +0100, Daniel Vetter wrote:
> No one looks at the major/minor versions except the unique/busid
> stuff. If we protect that with the master_mutex (since it also affects
> the unique of each master, oh well) we can mark these two IOCTL with
> DRM_UNLOCKED.
> 
> While doing this I realized that the comment for the magic_map is
> outdated, I've forgotten to update it in:
> 
> commit d2b34ee62b409a03c6fe43c07b779983be51d017
> Author: Daniel Vetter <daniel.vetter at ffwll.ch>
> Date:   Fri Jun 17 09:33:21 2016 +0200
> 
>     drm: Protect authmagic with master_mutex
> 
> Cc: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Emil Velikov <emil.l.velikov at gmail.com>
> Signed-off-by: Daniel Vetter <daniel.vetter at intel.com>

Ok, you have to jump around a bit to confirm the locking is correct.

(Mainly didn't get the connection between getunique and set_busid).
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the dri-devel mailing list