[PATCH 4/6] drm/atomic: Wait for vblank whenever a plane is added to state.

Maarten Lankhorst maarten.lankhorst at linux.intel.com
Mon Dec 12 10:27:41 UTC 2016


Op 08-12-16 om 16:43 schreef Daniel Vetter:
> On Thu, Dec 08, 2016 at 02:45:27PM +0100, Maarten Lankhorst wrote:
>> The current api doesn't take into account that whenever properties like
>> rotation or z-pos change we have to wait for vblank. To make sure
>> that we wait correctly, err on the side of caution and wait whenever
>> a plane is added to state.
> Why do we need to wait when rotation or zpos has changed? I'm a bit lost
> ... So rotation makes sense since often that means a special, rotated
> mapping (or a different offset on omap's TILER as a different example).
> But z-pos I have no idad why that matters.
It was meant as example, blocking commit always waits for the changes to be visible before returning, from what I understand.
So if any plane property changes we have to wait for the changes to be visible first.

~Maarten


More information about the dri-devel mailing list