[PATCH v3 06/20] drm: omapdrm: Handle FIFO underflow IRQs internally

[Laurent Pinchart]

Hi Tomi,

On Tuesday 20 Sep 2016 16:27:22 Tomi Valkeinen wrote:
> On 19/09/16 15:27, Laurent Pinchart wrote:
> > As the FIFO underflow IRQ handler just prints an error message to the
> > kernel log, simplify the code by not registering one IRQ handler per
> > plane but print the messages directly from the main IRQ handler.
> > 
> > Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> > ---
> > Changes since v1:
> > 
> > - Only register error IRQs that exist on the HW
> > ---
> > 
> > 
> > +static const u32 error_irqs[] = {
> > +	[OMAP_DSS_GFX] = DISPC_IRQ_GFX_FIFO_UNDERFLOW,
> > +	[OMAP_DSS_VIDEO1] = DISPC_IRQ_VID1_FIFO_UNDERFLOW,
> > +	[OMAP_DSS_VIDEO2] = DISPC_IRQ_VID2_FIFO_UNDERFLOW,
> > +	[OMAP_DSS_VIDEO3] = DISPC_IRQ_VID3_FIFO_UNDERFLOW,
> > +};
> 
> Actually, one comment: "error_irqs" is perhaps not a good name for this.
> "omap_underflow_irqs"?

That sounds good to me, I'll rename it.

> Or actually, maybe it would make sense to move this into dispc, and have
> a similar func to dispc_mgr_get_sync_lost_irq().

I'm certainly not a big fan of the omapdrm/omapdss split, but I think that's a 
more general problem. I'll likely need to reorganize that when trying to move 
panel and encoder drivers to drm_panel and drm_bridge. I propose revisiting 
the topic then.

-- 
Regards,

Laurent Pinchart