[PATCH libdrm] autogen.sh: set format.subjectPrefix and sendemail.to if needed

Eric Engestrom eric.engestrom at imgtec.com
Tue Dec 13 15:42:27 UTC 2016


On Tuesday, 2016-12-13 16:16:50 +0200, Jani Nikula wrote:
> On Tue, 13 Dec 2016, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> > Just set the rules automatically rather than asking each contributor to
> > update thing locally.
> >
> > Signed-off-by: Emil Velikov <emil.l.velikov at gmail.com>
> > ---
> >  autogen.sh | 6 ++++++
> >  1 file changed, 6 insertions(+)
> >
> > diff --git a/autogen.sh b/autogen.sh
> > index c896097..e936f04 100755
> > --- a/autogen.sh
> > +++ b/autogen.sh
> > @@ -9,6 +9,12 @@ cd "$srcdir"
> >  autoreconf --force --verbose --install || exit 1
> >  cd "$ORIGDIR" || exit $?
> >  
> > +git config --local --get format.subjectPrefix ||
> > +    git config --local format.subjectPrefix "PATCH libdrm"
> > +
> > +git config --local --get sendemail.to ||
> > +    git config --local sendemail.to "dri-devel at lists.freedesktop.org"
> > +
> 
> So I don't really play with libdrm source much, but can you expect this
> to only be run in a git repo? How about source/distro/tarball releases?

These will print an error like this and not do anything, so it should be
fine:
	error: could not lock config file .git/config: No such file or directory

These errors should be hidden though, as we don't care about such
failures, and the config reads should also be silenced as they will
print the previously set values.

With that fixed:
Reviewed-by: Eric Engestrom <eric.engestrom at imgtec.com>

> 
> BR,
> Jani.
> 
> >  if test -z "$NOCONFIGURE"; then
> >      "$srcdir"/configure "$@"
> >  fi
> 
> -- 
> Jani Nikula, Intel Open Source Technology Center


More information about the dri-devel mailing list