[PATCH] drm: Move vblank cleanup from unregister to release

Tomi Valkeinen tomi.valkeinen at ti.com
Wed Dec 14 11:18:07 UTC 2016


On 14/12/16 12:48, Laurent Pinchart wrote:
> Calling drm_vblank_cleanup() in drm_dev_unregister() causes issues with
> drivers that have moved away from the .load() and .unload() midlayer.
> Those drivers call drm_dev_unregister() as the first operation at unbind
> time, before shutting down the device. This results in warnings due to
> drm_vblank_cleanup() being called with vblank interrupts still active,
> and then to vblank events being sent after cleanup.
> 
> Fix the problem by moving vblank cleanup from drm_dev_unregister() to
> drm_dev_release() that is guaranteed to be called after drivers shut
> down the device.
> 
> Suggested-by: Daniel Vetter <daniel.vetter at ffwll.ch>
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

Tested-by: Tomi Valkeinen <tomi.valkeinen at ti.com>

 Tomi

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20161214/88d603a4/attachment.sig>


More information about the dri-devel mailing list