[PATCH] drm: rcar-du: enable VSPDs on R8A7791
Laurent Pinchart
laurent.pinchart at ideasonboard.com
Wed Dec 14 20:55:01 UTC 2016
Hi Sergei,
Thank you for the patch.
On Wednesday 14 Dec 2016 23:37:08 Sergei Shtylyov wrote:
> We're going to use R8A7791 VSPDs to control DU, so set the corresponding
> flag.
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov at cogentembedded.com>
For the same reason I nacked the corresponding patch to the VSP1 driver, I
have to nack this one as well. The Gen2 DU has native planes, this patch would
prevent using them. I don't see a good reason to do so.
> ---
> The patch is against David Airlie's 'linux.git' repo's 'drm-next' branch.
>
> drivers/gpu/drm/rcar-du/rcar_du_drv.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> Index: linux/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> ===================================================================
> --- linux.orig/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> +++ linux/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> @@ -90,7 +90,8 @@ static const struct rcar_du_device_info
> static const struct rcar_du_device_info rcar_du_r8a7791_info = {
> .gen = 2,
> .features = RCAR_DU_FEATURE_CRTC_IRQ_CLOCK
> - | RCAR_DU_FEATURE_EXT_CTRL_REGS,
> + | RCAR_DU_FEATURE_EXT_CTRL_REGS
> + | RCAR_DU_FEATURE_VSP1_SOURCE,
> .num_crtcs = 2,
> .routes = {
> /* R8A779[13] has one RGB output, one LVDS output and one
--
Regards,
Laurent Pinchart
More information about the dri-devel
mailing list