[PATCH v4 12/22] drm: omapdrm: Prevent processing the same event multiple times

[Tomi Valkeinen]

On 14/12/16 02:27, Laurent Pinchart wrote:
> The vblank interrupt is disabled after one occurrence, preventing the
> atomic update event from being processed twice. However, this also
> prevents the software frame counter from being updated correctly that
> would require vblank interrupts to be kept enabled while the CRTC is
> active.
> 
> In preparation for vblank interrupt fixes, make sure that the atomic
> update event will be processed once only when the vblank interrupt will
> be kept enabled.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> ---
> Changes since v3:
> 
> - Don't release and reacquire the spinlock for just one return
> - Remove unneeded (and unbalanced) drm_crtc_vblank_get()
> - Store the event in the atomic flush handler to avoid race condition
> - Use spin_lock_irq instead of spin_lock_irsave in flush handler
> ---
>  drivers/gpu/drm/omapdrm/omap_crtc.c | 23 +++++++++++++++--------
>  1 file changed, 15 insertions(+), 8 deletions(-)

Reviewed-by: Tomi Valkeinen <tomi.valkeinen at ti.com>

 Tomi


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20161215/52a6e22e/attachment.sig>