[PATCH 33/34] drm: Fix drm_mm search and insertion
chris at chris-wilson.co.uk
Thu Dec 15 12:57:49 UTC 2016
On Thu, Dec 15, 2016 at 02:28:32PM +0200, Joonas Lahtinen wrote:
> On ma, 2016-12-12 at 11:53 +0000, Chris Wilson wrote:
> > @@ -799,7 +706,7 @@ bool drm_mm_scan_add_block(struct drm_mm_scan *scan,
> > if (adj_end <= adj_start || adj_end - adj_start < scan->size)
> > return false;
> > - if (scan->flags == DRM_MM_CREATE_TOP)
> > + if (scan->flags == DRM_MM_INSERT_HIGH)
> Flags are usually checked with & if somebody wants to add them later.
> Otherwise you could call it "mode".
Once upon a time, they were intended to be flags. They have since
devolved back into a mode. The only suitable argument for my laziness
was what if I wanted to add a flag later!
Chris Wilson, Intel Open Source Technology Centre
More information about the dri-devel