[PATCH v4.1 22/22] drm: omapdrm: Perform initialization/cleanup at probe/remove time

[Tomi Valkeinen]

On 19/12/16 11:15, Laurent Pinchart wrote:
> The drm driver .load() operation is prone to race conditions as it
> initializes the driver after registering the device nodes. Its usage is
> deprecated, inline it in the probe function and call drm_dev_alloc() and
> drm_dev_register() explicitly.
> 
> For consistency inline the .unload() handler in the remove function as
> well.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> ---
> Changes since v4:
> 
> - Dropped drm_vblank_cleanup() in probe error path
> - Removed a duplicate call to omap_crtc_pre_uninit() in probe
> 
> Changes since v1:
> 
> - Call drm_kms_helper_poll_fini() before omap_fbdev_free() in the remove
>   handler.
> - Keep storing drm_device in the platform device private data.
> ---
>  drivers/gpu/drm/omapdrm/omap_connector.c |   2 -
>  drivers/gpu/drm/omapdrm/omap_drv.c       | 211 +++++++++++++++----------------
>  2 files changed, 105 insertions(+), 108 deletions(-)

Reviewed-by: Tomi Valkeinen <tomi.valkeinen at ti.com>

 Tomi

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20161219/ddfcd371/attachment.sig>