[PATCH v2] drm: exynos: Perform initialization/cleanup at probe/remove time

Daniel Stone daniel at fooishbar.org
Mon Dec 19 09:29:48 UTC 2016


Hi Laurent,

On 17 December 2016 at 22:29, Laurent Pinchart
<laurent.pinchart+renesas at ideasonboard.com> wrote:
> The drm driver .load() operation is prone to race conditions as it
> initializes the driver after registering the device nodes. Its usage is
> deprecated, inline it in the probe function and call drm_dev_alloc() and
> drm_dev_register() explicitly.
>
> For consistency inline the .unload() handler in the remove function as
> well.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> Reviewed-by: Sean Paul <seanpaul at chromium.org>
> Reviewed-by: Daniel Vetter <daniel.vetter at ffwll.ch>
> Reviewed-by: Daniel Stone <daniels at collabora.com>
> ---
> Changes since v1:
>
> - Use drm_device.dev instead of drm_device.platformdev in
>   exynos_drm_fbdev_create() as the platformdev field isn't set anymore

Yeah, that looks good. That was what I was getting at with my last
mail, but after a few roundtrips through LAVA trying to figure out
which extra config options I needed to get the panel to light up, and
being sick as well, I'd lost the will to live and didn't feel much
like figuring that one out myself. ;) Thanks!

Cheers,
Daniel


More information about the dri-devel mailing list