[PATCH 2/2] drm/fsl-dcu: check for clk_prepare_enable() error

Gabriel Krisman Bertazi krisman at collabora.co.uk
Wed Dec 28 18:53:01 UTC 2016


Fabio Estevam <festevam at gmail.com> writes:

> On Wed, Dec 28, 2016 at 4:38 PM, Gabriel Krisman Bertazi
> <krisman at collabora.co.uk> wrote:
>
>> This leaks tcon if clk_prepare_enable fails.
>
> No, it does not as tcon is allocated via devm_kzalloc().

Agreed.  But I think devm_kzalloc() only drops the memory once the
device is removed, which is not the case here, since failing
fsl_tcon_init is not fatal and the initialization continues in this
case.

--
Gabriel Krisman Bertazi


More information about the dri-devel mailing list