[drm:drm-fixes-mst 5/9] include/drm/drm_fixed.h:159: undefined reference to `__aeabi_uldivmod'

Lazare, Jordan Jordan.Lazare at amd.com
Thu Feb 4 19:34:44 UTC 2016


Hi Dave,

I have a small fix to the following patch in the drm-fixes-mst branch to resolve a 32-bit compile error. I've attached the patch separately and also squashed it into the previous change.

Thanks,
Jordan
 

commit 6d3d3d07381401ac6b89dfd429002c9d6ffda5e3
Author: Harry Wentland <harry.wentland at amd.com>
Date:   Fri Jan 22 17:07:25 2016 -0500

    drm: Add drm_fixp_from_fraction and drm_fixp2int_ceil

-----Original Message-----
From: Wentland, Harry 
Sent: Thursday, February 04, 2016 11:40 AM
To: Lazare, Jordan
Subject: FW: [drm:drm-fixes-mst 5/9] include/drm/drm_fixed.h:159: undefined reference to `__aeabi_uldivmod'



-----Original Message-----
From: kbuild test robot [mailto:fengguang.wu at intel.com] 
Sent: February 4, 2016 8:34 AM
To: Wentland, Harry <Harry.Wentland at amd.com>
Cc: kbuild-all at 01.org; Dave Airlie <airlied at redhat.com>; Deucher, Alexander <Alexander.Deucher at amd.com>
Subject: [drm:drm-fixes-mst 5/9] include/drm/drm_fixed.h:159: undefined reference to `__aeabi_uldivmod'

tree:   git://people.freedesktop.org/~airlied/linux.git drm-fixes-mst
head:   18ddcd63d22663841b8f61ee52733736bf3a4c7e
commit: 275e06c063ea920c4b89ee293b1975080f887b00 [5/9] drm/dp/mst: Calculate MST PBN with 31.32 fixed point
config: arm-exynos_defconfig (attached as .config)
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout 275e06c063ea920c4b89ee293b1975080f887b00
        # save the attached .config to linux build tree
        make.cross ARCH=arm 

All errors (new ones prefixed by >>):

   drivers/built-in.o: In function `drm_fixp_from_fraction':
>> include/drm/drm_fixed.h:159: undefined reference to `__aeabi_uldivmod'
   include/drm/drm_fixed.h:160: undefined reference to `__aeabi_uldivmod'

vim +159 include/drm/drm_fixed.h

210a0b9e Alex Deucher   2013-03-22  143  	if (shift > DRM_FIXED_POINT)
210a0b9e Alex Deucher   2013-03-22  144  		return result >> (shift - DRM_FIXED_POINT);
210a0b9e Alex Deucher   2013-03-22  145  
210a0b9e Alex Deucher   2013-03-22  146  	return result;
210a0b9e Alex Deucher   2013-03-22  147  }
210a0b9e Alex Deucher   2013-03-22  148  
6d3d3d07 Harry Wentland 2016-01-22  149  static inline s64 drm_fixp_from_fraction(s64 a, s64 b)
6d3d3d07 Harry Wentland 2016-01-22  150  {
6d3d3d07 Harry Wentland 2016-01-22  151  	s64 res;
6d3d3d07 Harry Wentland 2016-01-22  152  	bool a_neg = a < 0;
6d3d3d07 Harry Wentland 2016-01-22  153  	bool b_neg = b < 0;
6d3d3d07 Harry Wentland 2016-01-22  154  	u64 a_abs = a_neg ? -a : a;
6d3d3d07 Harry Wentland 2016-01-22  155  	u64 b_abs = b_neg ? -b : b;
6d3d3d07 Harry Wentland 2016-01-22  156  	u64 rem;
6d3d3d07 Harry Wentland 2016-01-22  157  
6d3d3d07 Harry Wentland 2016-01-22  158  	/* determine integer part */
6d3d3d07 Harry Wentland 2016-01-22 @159  	u64 res_abs = a_abs / b_abs;
6d3d3d07 Harry Wentland 2016-01-22  160  	rem = a_abs % b_abs;
6d3d3d07 Harry Wentland 2016-01-22  161  
6d3d3d07 Harry Wentland 2016-01-22  162  	/* determine fractional part */
6d3d3d07 Harry Wentland 2016-01-22  163  	{
6d3d3d07 Harry Wentland 2016-01-22  164  		u32 i = DRM_FIXED_POINT;
6d3d3d07 Harry Wentland 2016-01-22  165  
6d3d3d07 Harry Wentland 2016-01-22  166  		do {
6d3d3d07 Harry Wentland 2016-01-22  167  			rem <<= 1;

:::::: The code at line 159 was first introduced by commit
:::::: 6d3d3d07381401ac6b89dfd429002c9d6ffda5e3 drm: Add drm_fixp_from_fraction and drm_fixp2int_ceil

:::::: TO: Harry Wentland <harry.wentland at amd.com>
:::::: CC: Dave Airlie <airlied at redhat.com>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-drm-dp-mst-Fix-32-bit-fixed-point-division-calculati.patch
Type: application/octet-stream
Size: 984 bytes
Desc: 0001-drm-dp-mst-Fix-32-bit-fixed-point-division-calculati.patch
URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20160204/d5ddea10/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-drm-Add-drm_fixp_from_fraction-and-drm_fixp2int_ceil.patch
Type: application/octet-stream
Size: 2613 bytes
Desc: 0001-drm-Add-drm_fixp_from_fraction-and-drm_fixp2int_ceil.patch
URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20160204/d5ddea10/attachment-0001.obj>


More information about the dri-devel mailing list