[PATCH 01/21] drm/tilcdc: disable console switching during pm operations

[Daniel Vetter]

On Mon, Feb 08, 2016 at 10:00:20PM +0200, Tomi Valkeinen wrote:
> 
> 
> On 04/02/16 11:30, Jyri Sarha wrote:
> > From: Darren Etheridge <detheridge at ti.com>
> > 
> > The default behavior of consoles during power management operations is: On
> > entry to suspend a new console is allocated and switched to. On resume the
> > original console is restored.
> > 
> > However this isn't the observed behavior and the original console is not
> > restored. This commit avoids the problem by disabling the switching of
> > consoles at suspend/resume. This works because the driver already restores
> > all necessary hardware context during such pm operations.
> 
> I think this should be dropped, because no one else is doing the same,
> and the whole issue seems to be rather unclear.

Probably an oversight, since on the desktop most drivers to this (through
fb_info->skip_vt_switch).

We might have reached a time where we should flip over the default in the
drm fbdev helpers to always set this, and only override it for drivers
which are broken. Calling pm_set_vt_switch is kinda uncool, at least for
machines which can have multiple gpus.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch