[PATCH 11/16] drm/atmel-hldcd: removed optional dummy crtc mode_fixup function.

[Carlos Palminha]

Thanks Boris.

@Daniel, do you want me to resend this patch or will you fix it directly in mode-fixup git branch?

On 16-02-2016 16:58, Boris Brezillon wrote:
> On Tue, 16 Feb 2016 14:19:06 +0000
> Carlos Palminha <CARLOS.PALMINHA at synopsys.com> wrote:
> 
>> This patch set nukes all the dummy crtc mode_fixup implementations.
>> (made on top of Daniel topic/drm-misc branch)
> 
> There's 2 typos in the subject line (s/hldcd/hlcdc/ and
> s/removed/remove/), and you're removing an empty line after
> atmel_hlcdc_crtc_create() definition (which is correct, but I'm not
> sure it should be part of the same patch).
> Otherwise it looks good to me.
> Once you've fixed those 2 things, you can add my
> 
> Acked-by: Boris Brezillon <boris.brezillon at free-electrons.com>
> 
>>
>> Signed-off-by: Carlos Palminha <palminha at synopsys.com>
>> ---
>>  drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 9 ---------
>>  1 file changed, 9 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c
>> index 9863291..58c4f78 100644
>> --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c
>> +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c
>> @@ -121,13 +121,6 @@ static void atmel_hlcdc_crtc_mode_set_nofb(struct drm_crtc *c)
>>  			   cfg);
>>  }
>>  
>> -static bool atmel_hlcdc_crtc_mode_fixup(struct drm_crtc *crtc,
>> -					const struct drm_display_mode *mode,
>> -					struct drm_display_mode *adjusted_mode)
>> -{
>> -	return true;
>> -}
>> -
>>  static void atmel_hlcdc_crtc_disable(struct drm_crtc *c)
>>  {
>>  	struct drm_device *dev = c->dev;
>> @@ -261,7 +254,6 @@ static void atmel_hlcdc_crtc_atomic_flush(struct drm_crtc *crtc,
>>  }
>>  
>>  static const struct drm_crtc_helper_funcs lcdc_crtc_helper_funcs = {
>> -	.mode_fixup = atmel_hlcdc_crtc_mode_fixup,
>>  	.mode_set = drm_helper_crtc_mode_set,
>>  	.mode_set_nofb = atmel_hlcdc_crtc_mode_set_nofb,
>>  	.mode_set_base = drm_helper_crtc_mode_set_base,
>> @@ -349,4 +341,3 @@ fail:
>>  	atmel_hlcdc_crtc_destroy(&crtc->base);
>>  	return ret;
>>  }
>> -
> 
>