[PATCH 18/33] drm/omap: increase vblank wait timeout

Tomi Valkeinen tomi.valkeinen at ti.com
Wed Feb 24 09:41:30 UTC 2016

On 24/02/16 00:43, Laurent Pinchart wrote:
> Hi Tomi,
> Thank you for the patch.
> On Friday 19 February 2016 11:47:53 Tomi Valkeinen wrote:
>> omap_crtc_wait_pending() waits until the config changes have been taken
>> into use, usually at next vblank. The wait-timeout used is 50ms, which
>> usually is enough, but in some rare cases not.
>> As time wait-timeout is just a safety measure for cases where something
>> is broken, we can just as well increase the timeout considerably.
> Would it make sense to capture this in a comment in the code ?
> Apart from that,
> Acked-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

I added a comment:

 * timeout is set to a "sufficiently" high value, which should cover
 * a single frame refresh even on slower displays.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20160224/234d0685/attachment.sig>

More information about the dri-devel mailing list