[PATCH 30/33] drm/omap: verify that fb plane pitches are the same

Tomi Valkeinen tomi.valkeinen at ti.com
Thu Feb 25 15:56:57 UTC 2016

On 24/02/16 01:02, Laurent Pinchart wrote:
> Hi Tomi,
> Thank you for the patch.
> On Friday 19 February 2016 11:48:05 Tomi Valkeinen wrote:
>> The DSS hardware uses the same ROW_INC value for both Y and UV planes
>> for NV12 format. This means that the pitches of the Y and UV planes have
>> to match. omapdrm doesn't check this at the moment, and this can lead
>> into a broken NV12 fb on the screen.
>> This patch adds the check.
>> Signed-off-by: Tomi Valkeinen <tomi.valkeinen at ti.com>
> Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> We can probably simplify the implementation further as most of the checks in 
> the loop apply to the first place only. Would you like me to give it a go ?

"place" is plane? I don't quite understand what you mean. The checks
apply to all planes.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20160225/7e27c7ff/attachment.sig>

More information about the dri-devel mailing list