[PATCH 30/33] drm/omap: verify that fb plane pitches are the same

Laurent Pinchart laurent.pinchart at ideasonboard.com
Fri Feb 26 09:27:52 UTC 2016


Hi Tomi,

On Friday 26 February 2016 11:12:21 Tomi Valkeinen wrote:
> On 26/02/16 10:55, Laurent Pinchart wrote:
> >> I don't quite understand what you mean. The checks apply to all planes.
> > 
> > My point is that if you add a check to ensure that the pitch is identical
> > in all planes, the other tests on the pitch don't have to be repeated for
> > every plane.
> 
> Hmm... The other tests also depend on the plane's bpp, so I'm not sure
> if any of those can be skipped.
> 
> But I agree, the loop with the checks does look somewhat complex, and
> there's probably room for improvement.

It doesn't have to be cleaned as part of this patch though, we can handle that 
later.

-- 
Regards,

Laurent Pinchart



More information about the dri-devel mailing list