drm/amd/powerplay: fix a reversed condition

SF Markus Elfring elfring at users.sourceforge.net
Tue Jan 5 04:36:58 PST 2016


> Yes.  This was a Smatch warning

Thanks for this acknowledgement.

How do you think about to indicate such a detail more often in
your update suggestions and bug reports?

Would it make sense to mark contributions from automatic static
source code analysis by a dedicated tag in the commit message?


> but Coccinelle can also find this kinds of inconsistent NULL checking.

Should we try together to extend the script collection for the
semantic patch language around such use cases?

Regards,
Markus



More information about the dri-devel mailing list