[PATCH] drm/radeon: fix trivial typo in warning message
Eric Engestrom
eric.engestrom at imgtec.com
Fri Jan 8 04:10:50 PST 2016
Yes, a quick grep shows the same typo in several places:
> $ grep -Rwn 'to small' drivers/gpu/
> drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c:544: DRM_ERROR("BO to small for addr 0x%010Lx %d %d\n",
> drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c:648: DRM_ERROR("buffer (%d) to small (%d / %d)!\n", cmd,
> drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c:656: DRM_ERROR("buffer (%d) to small (%d / %d)!\n", cmd,
> drivers/gpu/drm/radeon/radeon_device.c:1153: dev_warn(rdev->dev, "VM size (%d) to small, min is 1GB\n",
> drivers/gpu/drm/radeon/radeon_vce.c:501: DRM_ERROR("buffer to small (%d / %d)!\n",
> drivers/gpu/drm/radeon/radeon_uvd.c:563: DRM_ERROR("buffer (%d) to small (%d / %d)!\n", cmd,
BTW there's also a 'to large' one:
> drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c:342: /* clamp timeout if it's to large */
On 08/01/16 09:35, Christian König wrote:
> Am 08.01.2016 um 01:22 schrieb Alexandre Demers:
>> Signed-off-by: Alexandre Demers <alexandre.f.demers at gmail.com>
>
> Reviewed-by: Christian König <christian.koenig at amd.com>.
>
> We probably need to fix this in amdgpu as well.
>
> Thanks for the help,
> Christian.
>
>> ---
>> drivers/gpu/drm/radeon/radeon_device.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/radeon/radeon_device.c b/drivers/gpu/drm/radeon/radeon_device.c
>> index c566993..4197ca1 100644
>> --- a/drivers/gpu/drm/radeon/radeon_device.c
>> +++ b/drivers/gpu/drm/radeon/radeon_device.c
>> @@ -1150,7 +1150,7 @@ static void radeon_check_arguments(struct radeon_device *rdev)
>> }
>>
>> if (radeon_vm_size < 1) {
>> - dev_warn(rdev->dev, "VM size (%d) to small, min is 1GB\n",
>> + dev_warn(rdev->dev, "VM size (%d) too small, min is 1GB\n",
>> radeon_vm_size);
>> radeon_vm_size = 4;
>> }
>
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
>
More information about the dri-devel
mailing list