[PATCH] drm/i2c: tda998x: Choose between atomic or non atomic dpms helper

Russell King - ARM Linux linux at arm.linux.org.uk
Mon Jan 18 03:15:05 PST 2016


On Mon, Jan 18, 2016 at 09:52:27AM +0000, Liviu.Dudau at arm.com wrote:
> On Sat, Jan 16, 2016 at 10:17:54PM +0200, Jyri Sarha wrote:
> > It just makes me wonder if drm_atomic_helper_connector_dpms() should
> > call the legacy callback automatically if DRIVER_ATOMIC is not set or
> > at least bail out gracefully with an error message. Then again it may
> > be overkill if the tda998x is the only driver that need to support
> > both situations.
> 
> I would guess that in general it makes sense for the core code to do what
> you suggest, but the idea is to try to encourage the drivers to convert
> to atomic ops rather than give them too many crutches. And the tda998x will
> need this for a short period of time until tilcdc converts as well.

It's not just tilcdc that this driver is used by.

I have no plans at present to convert armada to atomic mode setting,
although I occasionally push it (I hope) towards that goal.  This
isn't going to happen quickly, because I've other areas that need
work too.

-- 
RMK's Patch system: http://www.arm.linux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.


More information about the dri-devel mailing list