[PATCH] drm/radeon: only init fbdev if we have connectors

Mike Lothian mike at fireburn.co.uk
Mon Jan 25 15:57:21 PST 2016


Is something similar required for AMDGPU too?

On Mon, 25 Jan 2016 at 23:06 Rob Clark <robdclark at gmail.com> wrote:

> This fixes an issue that was noticed on an optimus/prime laptop with
> a kernel that was old enough to not support the integrated intel gfx
> (which was driving all the outputs), but did have support for the
> discrete radeon gpu.  The end result was not falling back to VESA and
> leaving the user with a black screen.
>
> (Plus it is kind of silly to create an framebuffer device if there
> are no outputs hooked up to the gpu.)
>
> Signed-off-by: Rob Clark <robdclark at gmail.com>
> ---
>  drivers/gpu/drm/radeon/radeon_display.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_display.c
> b/drivers/gpu/drm/radeon/radeon_display.c
> index 1eca0ac..f8e776c 100644
> --- a/drivers/gpu/drm/radeon/radeon_display.c
> +++ b/drivers/gpu/drm/radeon/radeon_display.c
> @@ -1670,8 +1670,10 @@ int radeon_modeset_init(struct radeon_device *rdev)
>         /* setup afmt */
>         radeon_afmt_init(rdev);
>
> -       radeon_fbdev_init(rdev);
> -       drm_kms_helper_poll_init(rdev->ddev);
> +       if (!list_empty(&rdev->ddev->mode_config.connector_list)) {
> +               radeon_fbdev_init(rdev);
> +               drm_kms_helper_poll_init(rdev->ddev);
> +       }
>
>         /* do pm late init */
>         ret = radeon_pm_late_init(rdev);
> --
> 2.5.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20160125/42fc5cfb/attachment-0001.html>


More information about the dri-devel mailing list