[PATCH 1/2] drm/etnaviv: fix get pages error path in etnaviv_gem_vaddr

Russell King - ARM Linux linux at arm.linux.org.uk
Tue Jan 26 08:45:52 PST 2016


On Tue, Jan 26, 2016 at 04:45:25PM +0100, Lucas Stach wrote:
> In case that etnaviv_gem_get_pages is unable to get the required
> pages the object mutex needs to be unlocked. Also return NULL in
> this case instead of propagating the error, as callers of this
> function might not be prepared to handle a pointer error, but
> expect this call to follow the semantics of a plain vmap to return
> NULL in case of an error.

If we're giving it vmap() semantics, then let's add another patch
which calls this function etnaviv_gem_vmap()...

-- 
RMK's Patch system: http://www.arm.linux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.


More information about the dri-devel mailing list