[PATCH libdrm] tests: util: Fixup util_open() parameter order

Emil Velikov emil.l.velikov at gmail.com
Tue Jan 26 13:07:28 PST 2016


On 5 January 2016 at 14:21, Thierry Reding <thierry.reding at gmail.com> wrote:
> From: Thierry Reding <treding at nvidia.com>
>
> util_open() takes a device parameter, followed by a module parameter.
> The existing tests used the drmOpen() function, which uses a different
> ordering of the parameters, and the old ordering was accidentally kept
> during the conversion.
>
> Signed-off-by: Thierry Reding <treding at nvidia.com>
> ---
> Evidently I didn't properly test this. Things do work in most cases
> with the current code because of the auto-detection, but there will
> be cases where it fails.
>
Having the module name identical to the device name also helps ;-)
But seriously - nicely spotted. I'll going through the list and I'll
push this out shortly.

-Emil


More information about the dri-devel mailing list