Re: [PATCH libdrm] Synchronize drm/drm_fourcc.h with Linux’ version
Emil Velikov
emil.l.velikov at gmail.com
Wed Jan 27 05:28:04 PST 2016
On 27 January 2016 at 11:42, Daniel Stone <daniel at fooishbar.org> wrote:
> Hey,
>
> On 27 January 2016 at 09:38, Daniel Vetter <daniel at ffwll.ch> wrote:
>> On Tue, Jan 26, 2016 at 09:04:18PM +0000, Emil Velikov wrote:
>>> On 11 January 2016 at 19:32, Emmanuel Gil Peyrot
>>> <emmanuel.peyrot at collabora.com> wrote:
>>> > This adds R8, RG88 and GR88, as well as the non-subsampled NV24/NV42 formats.
>>> >
>>> Err... please don't copy/paste 'random' hunks here. These headers
>>> should be imported from the kernel with the commit message mentioning
>>> the sha of their origin.
>>>
>>> I've been procrastinating^Wwaiting on some upstream changes to land
>>> and with those in place I'll update the Makefile to import things
>>> properly.
>>
>> Yeah, we should have some scripts in libdrm that runs make
>> headers_install, copies over the latest generated uapi headers for drm and
>> then creates a commit with the sha1 it was generated from. Maybe even a
>> rule that the sha1 has to be from Dave's drm-next.
>
> Yeah, it's certainly doable, once some kernel-internal details are
> shuffled out of uapi/drm/drm_mode.h.
What do you have in mind - DRM_MODE_PICTURE_ASPECT_* ? I'm thinking
more that we should bring back DRM_MODE_OBJECT_* as it breaks libdrm
and maybe other userspace.
Feel free to let me know here or in the patch I just sent (didn't
realise and I Cc'd your collabora email).
Thanks
Emil
More information about the dri-devel
mailing list