[PATCH -next] drm/msm/hdmi: use PTR_ERR_OR_ZERO() to simplify the code

Rob Clark robdclark at gmail.com
Tue Jul 12 12:36:38 UTC 2016


thanks, I'll pick this up for my 4.8 pull req

BR,
-R

On Tue, Jul 12, 2016 at 7:06 AM,  <weiyj_lk at 163.com> wrote:
> From: Wei Yongjun <yongjun_wei at trendmicro.com.cn>
>
> Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR.
>
> Generated by: scripts/coccinelle/api/ptr_ret.cocci
>
> Signed-off-by: Wei Yongjun <yongjun_wei at trendmicro.com.cn>
> ---
>  drivers/gpu/drm/msm/hdmi/hdmi.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/hdmi/hdmi.c b/drivers/gpu/drm/msm/hdmi/hdmi.c
> index 33bf52c..9737207 100644
> --- a/drivers/gpu/drm/msm/hdmi/hdmi.c
> +++ b/drivers/gpu/drm/msm/hdmi/hdmi.c
> @@ -537,10 +537,7 @@ static int msm_hdmi_register_audio_driver(struct hdmi *hdmi, struct device *dev)
>                                                          PLATFORM_DEVID_AUTO,
>                                                          &codec_data,
>                                                          sizeof(codec_data));
> -       if (IS_ERR(hdmi->audio_pdev))
> -               return PTR_ERR(hdmi->audio_pdev);
> -
> -       return 0;
> +       return PTR_ERR_OR_ZERO(hdmi->audio_pdev);
>  }
>
>  static int msm_hdmi_bind(struct device *dev, struct device *master, void *data)
>
>
>
>


More information about the dri-devel mailing list