[PATCH v5 0/4] Generic zpos property

Daniel Vetter daniel at ffwll.ch
Tue Jul 12 14:01:58 UTC 2016


On Fri, Jul 08, 2016 at 09:06:18AM +0200, Benjamin Gaignard wrote:
> htmldocs get information directly from the comments in .h and .c files

You're both correct: There's another table which is supposed to list _all_
properties. It's a bit a mess, and should be split up/cleaned up, but
that's a longer-term thing. Please add zpos there too.

See Documentation/gpu/kms-properties.csv

Cheers, Daniel
> 
> 2016-07-07 18:09 GMT+02:00 Tobias Jakobi <tjakobi at math.uni-bielefeld.de>:
> > Benjamin Gaignard wrote:
> >> zpos new fields are correctly documented in drm-kms.html after running
> >> make htmldocs.
> > I'm not sure I understand. Where does htmldocs get the information from
> > then?
> >
> > - Tobias
> >
> >
> >> Benjamin
> >>
> >> 2016-07-07 16:01 GMT+02:00 Tobias Jakobi <tjakobi at math.uni-bielefeld.de>:
> >>> Hello Benjamin,
> >>>
> >>>
> >>> Benjamin Gaignard wrote:
> >>>> version 5:
> >>>> rebased on drm-next where Documentation/DocBook/gpu.tmpl doesn't
> >>>> exist anymore.
> >>> I think the documentation has just moved to Documentation/gpu, so the
> >>> zpos property should be documented there then.
> >>>
> >>>
> >>> With best wishes,
> >>> Tobias
> >>>
> >>>
> >>>> rework sti patch because some plane functions have changed since v4
> >>>>
> >>>> version 4:
> >>>> make sure that normalized zpos value is stay in the defined property
> >>>> range and warn user if not.
> >>>> Fix NULL pointer bug in rcar-du while setting zpos value.
> >>>> No changes in the other drivers.
> >>>>
> >>>> version 3:
> >>>> use kmalloc_array instead of kmalloc.
> >>>> Correct normalize_zpos computation (comeback to Mareck original code)
> >>>>
> >>>> version 2:
> >>>> add a zpos property into drm_plane structure to simplify code.
> >>>> This allow to get/set zpos value in core and not in drivers code.
> >>>> Fix various remarks.
> >>>>
> >>>> version 1:
> >>>> refactor Marek's patches to have per plane zpos property instead of only
> >>>> one in core.
> >>>>
> >>>> Benjamin Gaignard (2):
> >>>>   drm: sti: use generic zpos for plane
> >>>>   drm: rcar: use generic code for managing zpos plane property
> >>>>
> >>>> Marek Szyprowski (2):
> >>>>   drm: add generic zpos property
> >>>>   drm/exynos: use generic code for managing zpos plane property
> >>>>
> >>>>  drivers/gpu/drm/Makefile                  |   2 +-
> >>>>  drivers/gpu/drm/drm_atomic.c              |   4 +
> >>>>  drivers/gpu/drm/drm_atomic_helper.c       |   6 +
> >>>>  drivers/gpu/drm/drm_blend.c               | 227 ++++++++++++++++++++++++++++++
> >>>>  drivers/gpu/drm/drm_crtc_internal.h       |   4 +
> >>>>  drivers/gpu/drm/exynos/exynos_drm_drv.h   |   2 -
> >>>>  drivers/gpu/drm/exynos/exynos_drm_plane.c |  67 ++-------
> >>>>  drivers/gpu/drm/exynos/exynos_mixer.c     |   6 +-
> >>>>  drivers/gpu/drm/rcar-du/rcar_du_crtc.c    |   2 +-
> >>>>  drivers/gpu/drm/rcar-du/rcar_du_drv.h     |   1 -
> >>>>  drivers/gpu/drm/rcar-du/rcar_du_kms.c     |   5 -
> >>>>  drivers/gpu/drm/rcar-du/rcar_du_plane.c   |   9 +-
> >>>>  drivers/gpu/drm/rcar-du/rcar_du_plane.h   |   2 -
> >>>>  drivers/gpu/drm/sti/sti_cursor.c          |   4 +-
> >>>>  drivers/gpu/drm/sti/sti_gdp.c             |   4 +-
> >>>>  drivers/gpu/drm/sti/sti_hqvdp.c           |   4 +-
> >>>>  drivers/gpu/drm/sti/sti_mixer.c           |   9 +-
> >>>>  drivers/gpu/drm/sti/sti_plane.c           |  76 ++++------
> >>>>  drivers/gpu/drm/sti/sti_plane.h           |   7 +-
> >>>>  include/drm/drm_crtc.h                    |  30 ++++
> >>>>  20 files changed, 324 insertions(+), 147 deletions(-)
> >>>>  create mode 100644 drivers/gpu/drm/drm_blend.c
> >>>>
> >>>> Cc: Inki Dae <inki.dae at samsung.com>
> >>>> Cc: Daniel Vetter <daniel at ffwll.ch>
> >>>> Cc: Ville Syrjala <ville.syrjala at linux.intel.com>
> >>>> Cc: Joonyoung Shim <jy0922.shim at samsung.com>
> >>>> Cc: Seung-Woo Kim <sw0312.kim at samsung.com>
> >>>> Cc: Andrzej Hajda <a.hajda at samsung.com>
> >>>> Cc: Krzysztof Kozlowski <k.kozlowski at samsung.com>
> >>>> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie at samsung.com>
> >>>> Cc: Tobias Jakobi <tjakobi at math.uni-bielefeld.de>
> >>>> Cc: Gustavo Padovan <gustavo at padovan.org>
> >>>> Cc: vincent.abriou at st.com
> >>>> Cc: fabien.dessenne at st.com
> >>>> Cc: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> >>>>
> >>>
> >>
> >>
> >>
> >
> 
> 
> 
> -- 
> Benjamin Gaignard
> 
> Graphic Working Group
> 
> Linaro.org │ Open source software for ARM SoCs
> 
> Follow Linaro: Facebook | Twitter | Blog

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch


More information about the dri-devel mailing list