[PATCH 1/1] gpu: drm: omapdrm: dss-of: add missing of_node_put after calling of_parse_phandle

[Peter Chen]

>
>Just an aside: When you do the same bugfix for multiple places it's good practice to
>submit it as one series (and cc everyone involved). Increases the odds that someone
>is in a good mood and reviews them all, instead of just the one affecting their own
>driver.

Thanks, I realized that, and did it for later fixes for drm.
But if the bug fixes are at several subsystems, I think
we should split patch set per subsystem.

Peter

>
>> ---
>>  drivers/gpu/drm/omapdrm/dss/dss-of.c | 7 ++++---
>>  1 file changed, 4 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/omapdrm/dss/dss-of.c
>> b/drivers/gpu/drm/omapdrm/dss/dss-of.c
>> index bf407b6..1ee6e5e 100644
>> --- a/drivers/gpu/drm/omapdrm/dss/dss-of.c
>> +++ b/drivers/gpu/drm/omapdrm/dss/dss-of.c
>> @@ -126,15 +126,16 @@ u32 dss_of_port_get_port_number(struct
>> device_node *port)
>>
>>  static struct device_node *omapdss_of_get_remote_port(const struct
>> device_node *node)  {
>> -	struct device_node *np;
>> +	struct device_node *np, *np_parent;
>>
>>  	np = of_parse_phandle(node, "remote-endpoint", 0);
>>  	if (!np)
>>  		return NULL;
>>
>> -	np = of_get_next_parent(np);
>> +	np_parent = of_get_next_parent(np);
>> +	of_node_put(np);
>>
>> -	return np;
>> +	return np_parent;
>>  }
>>
>>  struct device_node *
>> --
>> 1.9.1
>>
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
>--
>Daniel Vetter
>Software Engineer, Intel Corporation
>http://blog.ffwll.ch