[PATCH] drm/edid: move DDC_SEGMENT_ADDR into drm_edid.h
Shawn Guo
shawnguo at kernel.org
Thu Jul 14 13:21:03 UTC 2016
On Thu, Jul 14, 2016 at 02:45:41PM +0200, Daniel Vetter wrote:
> On Thu, Jul 14, 2016 at 05:00:28PM +0800, Shawn Guo wrote:
> > The same definition of DDC_SEGMENT_ADDR is currently defined in two
> > places, drm_edid.c and inno_hdmi.h. Let's consolidate the definition
> > into drm_edid.h in the same way that DDC_ADDR is defined.
> >
> > Signed-off-by: Shawn Guo <shawnguo at kernel.org>
>
> What really should be done here is nuke the fake i2c adapter in
> inno_hdmi.c and instead just directly read the edid from the hdim IP.
> Using drm_get_edid for something that's not backed by a real i2c bus is
> bonghits.
This patch just makes some change literally. I do not understand how
the IP block works at all. I thought the HDMI IP talks to monitors
using I2C protocol implemented inside the IP block. I added Rockchip
folks to see if we can get any clarifications from them.
Shawn
More information about the dri-devel
mailing list