[PATCH v3 1/2] dt-bindings: tc358767: add DT documentation

[Philipp Zabel]

Am Sonntag, den 17.07.2016, 13:55 +0530 schrieb Archit Taneja:
> 
> On 7/17/2016 4:04 AM, Rob Herring wrote:
> > On Wed, Jul 13, 2016 at 09:07:10AM +0200, Philipp Zabel wrote:
> >> Add DT binding documentation for the Toshiba TC358767 eDP bridge.
> >>
> >> Signed-off-by: Philipp Zabel <p.zabel at pengutronix.de>
> >> ---
> >>   .../bindings/display/bridge/toshiba,tc358767.txt   | 51 ++++++++++++++++++++++
> >>   1 file changed, 51 insertions(+)
> >>   create mode 100644 Documentation/devicetree/bindings/display/bridge/toshiba,tc358767.txt
> >>
> >> diff --git a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358767.txt b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358767.txt
> >> new file mode 100644
> >> index 0000000..05ada28
> >> --- /dev/null
> >> +++ b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358767.txt
> >> @@ -0,0 +1,51 @@
> >> +Toshiba TC358767 eDP bridge bindings
> >> +
> >> +Required properties:
> >> + - compatible: "toshiba,tc358767"
> >> + - reg: i2c address of the bridge, 0x68 or 0x0f, depending on bootstrap pins
> >> + - clock-names: should be "ref"
> >> + - clocks: OF device-tree clock specification for refclk input. The reference
> >> +   clock rate must be 13 MHz, 19.2 MHz, 26 MHz, or 38.4 MHz.
> >> +
> >> +Optional properties:
> >> + - shutdown-gpios: OF device-tree gpio specification for SD pin
> >> +                   (active high shutdown input)
> >> + - reset-gpios: OF device-tree gpio specification for RSTX pin
> >> +                (active low system reset)
> >> + - ports: the ports node can contain video interface port nodes to connect
> >> +   to a DPI/DSI source and to an eDP/DP sink according to [1][2]:
> >> +    - port at 0: DSI input port
> >> +    - port at 1: DPI input port
> >> +    - port at 2: eDP/DP output port
> >> +
> >> +[1]: Documentation/devicetree/bindings/graph.txt
> >> +[2]: Documentation/devicetree/bindings/media/video-interfaces.txt
> >> +
> >> +Example:
> >> +	edp-bridge at 68 {
> >> +		compatible = "toshiba,tc358767";
> >> +		reg = <0x68>;
> >> +		shutdown-gpios = <&gpio3 23 GPIO_ACTIVE_HIGH>;
> >> +		reset-gpios = <&gpio3 24 GPIO_ACTIVE_LOW>;
> >> +		clock-names = "ref";
> >> +		clocks = <&edp_refclk>;
> >> +
> >> +		ports {
> >
> > You are missing #size-cells and #address-cells here, otherwise:
> >
> > Acked-by: Rob Herring <robh at kernel.org>
> 
> Thanks, I'll fix it up before sending a pull request.

Thank you for the fixup.

regards
Philipp