[PATCH v2 3/4] drm/dsi: Implement dcs set/get display brightness

Vinay Simha simhavcs at gmail.com
Mon Jul 18 07:59:12 UTC 2016


yes, it is wrong.
it supposed to be

if(err <= 0) {
          if(err == 0)

will resend a modified version

On Fri, Jul 15, 2016 at 2:50 AM, Emil Velikov <emil.l.velikov at gmail.com>
wrote:

> On 13 July 2016 at 17:44, Vinay Simha BN <simhavcs at gmail.com> wrote:
>
> > +int mipi_dsi_dcs_get_display_brightness(struct mipi_dsi_device *dsi,
> > +                                       u16 *brightness)
> > +{
> > +       ssize_t err;
> > +
> > +       err = mipi_dsi_dcs_read(dsi, MIPI_DCS_GET_DISPLAY_BRIGHTNESS,
> > +                               brightness, sizeof(*brightness));
> > +       if (err < 0) {
> > +               if (err == 0)
> Something looks fishy here. This can never be true, can it ?
>
>  -Emil
>



-- 
Regards,

Vinay Simha.B.N.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20160718/6534a248/attachment-0001.html>


More information about the dri-devel mailing list