[PATCH] drm/imx: imx-ldb: do not try to dereference crtc->state->state in encoder mode_set

Philipp Zabel p.zabel at pengutronix.de
Fri Jul 22 10:57:15 UTC 2016


Am Freitag, den 22.07.2016, 11:35 +0200 schrieb Daniel Vetter:
[...]
> Proper fix would be to roll out atomic_ versions of all teh encoder
> callbacks where we additionally pass both the crtc state and the connector
> state. Then there's no need for walking connector lists like that. And in
> the atomic helpers those two states are always readily available, and
> passing them down to callbacks is also what we will do in i915. I'd be
> happy to merge such a patch.

Thanks, that is a good idea. Which encoder callbacks besides mode_set ->
atomic_mode_set are you thinking of, though? enable/disable?

regards
Philipp



More information about the dri-devel mailing list