[PATCH v7 1/4] drm: add generic zpos property

Emil Velikov emil.l.velikov at gmail.com
Thu Jul 28 12:55:02 UTC 2016


Hi Benjamin,

Just spotted a couple of small bits which, imho, should be fine with
squashing with follow up patch(es).

On 28 July 2016 at 09:07, Benjamin Gaignard
<benjamin.gaignard at linaro.org> wrote:

> +EXPORT_SYMBOL(drm_atomic_helper_normalize_zpos);
The symbols is internal only thus the EXPORT_SYMBOL notation isn't needed.
Rule of thumb - interfaces used by other modules are declared in
include/drm and the symbol(s) should be annotated with EXPORT_SYMBOL*

> +
> +int drm_plane_atomic_set_zpos_property(struct drm_plane *plane,
> +                                      struct drm_plane_state *state,
> +                                      struct drm_property *property,
> +                                      uint64_t val);
> +
> +int drm_plane_atomic_get_zpos_property(struct drm_plane *plane,
> +                                      const struct drm_plane_state *state,
> +                                      struct drm_property *property,
> +                                      uint64_t *val);
> +
Dead code/declarations ?

Cheers,
Emil


More information about the dri-devel mailing list