virglrenderer regression in commit ad4f0f1941677c

[Marc-André Lureau]

Hi

----- Original Message -----
> Hi,
> 
> This commit in virglrenderer causes a regression in Android for me.
> The parameters that get passed in are last_level = 8, width = 1. I'm
> not really sure if this is valid (I'm guessing there should be some
> min width?), or where I should be looking to fix this. Any ideas?
> 
> commit ad4f0f1941677c6cd78bcd14348cd99ae7dd7527
> Author: Marc-André Lureau <marcandre.lureau at redhat.com>
> Date:   Tue Jan 19 14:37:50 2016 +0100
> 
>     renderer: reject large LOD values
> 
>     Or we could sit for a very long time in some further loops.
> 
>     Fix found thanks to american fuzzy lop.
> 
>     Signed-off-by: Marc-André Lureau <marcandre.lureau at redhat.com>


I don't know whether a texture of 1x1 with a LOD of 8 is valid. I remember that fix was related to invalid virgl command stream found by afl, that would be able to loop millions of iterations in some code, such as vrend_renderer_resource_create(). I wonder if you could trace it back to some client code. Also worth if there is a valid opengl reproducer, that could be a new piglit test.

Btw, there is a virglrenderer mailing list: virglrenderer-devel at lists.freedesktop.org