[PATCH v4] drm: Only create a cmdline mode if no probed modes match
Daniel Vetter
daniel at ffwll.ch
Thu Jun 2 13:12:26 UTC 2016
On Thu, Jun 02, 2016 at 02:30:40PM +0300, Ville Syrjälä wrote:
> On Thu, Jun 02, 2016 at 11:52:17AM +0100, Chris Wilson wrote:
> > On Thu, Jun 02, 2016 at 11:38:26AM +0200, Radek Dostál wrote:
> > > On 06/01/2016 11:50 AM, Chris Wilson wrote:
> > > >Fixes regression from
> > > >
> > > >commit eaf99c749d43ae74ac7ffece5512f3c73f01dfd2
> > > >Author: Chris Wilson<chris at chris-wilson.co.uk>
> > > >Date: Wed Aug 6 10:08:32 2014 +0200
> > > >
> > > > drm: Perform cmdline mode parsing during connector initialisation
> > > >
> > > >that breaks HDMI output on BeagleBone Black with LG TV (model 19LS4R-ZA).
> > >
> > > please remove this from the commit message. The original bug is no
> > > longer reproducible with 4.7-rc1
> >
> > If there's no motivation for the patch anymore, it can just wither away
> > in one of my old trees.
> >
> > Does anyone care about pruning the autogenerated video= mode if a probed
> > one matches? Presumably, it is still visible to userspace and switching
> > to it will cause the same issue as before? Or was it always a driver
> > bug (failing to set the mode)?
>
> IMO the patch makes total sense even if it's not needed for this
> particular bug. Feel free to add
>
> Reviewed-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
Agreed. I dropped the cc: stable and adjusted the commit message to
explain the situation. Merged to drm-misc, thanks.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
More information about the dri-devel
mailing list