[PATCH 15/23] drm: omapdrm: Don't expose the omap_irq_(un)register() functions

Laurent Pinchart laurent.pinchart at ideasonboard.com
Mon Jun 6 00:53:17 UTC 2016


Hi Tomi,

On Wednesday 11 May 2016 14:05:48 Tomi Valkeinen wrote:
> On 26/04/16 23:35, Laurent Pinchart wrote:
> > The functions are not used outside of their compilation unit, make them
> > static.
> 
> The patch doesn't seem to match the description. If I'm not mistaken,
> the patch is doing: remove __omap_irq_* funcs, remove parameter from the
> irq callback, make funcs static.
>
> Combining everything into one patch makes it difficult to review,
> especially if the description doesn't explain what's done.

The purpose of the patch is to stop exposing the omap_irq_(un)register() 
functions (as you describe by "make funcs static"). As further cleanup it then 
merges __omap_irq_(un)register() with omap_irq_(un)register(), and simplifies 
the IRQ handler API by removing an unused parameter.

I'll split this in two patches, one that stops exposing functions and merges 
them, and another one that removes the parameter.

-- 
Regards,

Laurent Pinchart



More information about the dri-devel mailing list