[PATCH] drm/vc4: clean up error exit path on failed dpi_connector allocation

Eric Anholt eric at anholt.net
Mon Jun 6 21:29:26 UTC 2016


Colin King <colin.king at canonical.com> writes:

> From: Colin Ian King <colin.king at canonical.com>
>
> There is redundant code in the clean up exit path when dpi_connector
> fails to be allocated.  The current code checks if connector is NULL
> before destroying it, in fact, connector is NULL at this point so
> the check is redundant and can be removed. The final clean up is
> that we can remove the goto fail with a simple return and the unused
> variable ret.
>
> Signed-off-by: Colin Ian King <colin.king at canonical.com>

Reviewed and pulled to drm-vc4-next.  Thanks!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20160606/f4a78dfc/attachment.sig>


More information about the dri-devel mailing list