[PATCH v5 1/2] drm/bridge: Add sii902x driver

Meng Yi meng.yi at nxp.com
Tue Jun 7 02:40:56 UTC 2016


Hi Boris,

Sorry for reply late, I was on PTO. And another PTO on  June 9~11, 2016.UTC+8

>
> > > +       gpiod_set_value(sii902x->reset_gpio, 1);
> > > +
> > > +       msleep(100);
> > Ouch that is some juicy number. Can we get a comment with
> > reasoning/origin of it ?
> 
> As already explained to Maxime, I just don't know why this is needed, simply
> because I don't have access to the datasheet and I just based my
> implementation on another driver.
> I can add a comment stating that this was extracted from another
> implementation, but with no explanation on why this is needed.
> 
> Meng, do you have any information about startup-time, or something like that?
> 

I had checked the datasheet of sii9022a, which said the Min of TRESET is 100 μs, and Max is not specified.

Regards,
Meng


More information about the dri-devel mailing list