[PATCH 16/27] drm/i915: Use atomic commits for legacy page_flips

Daniel Vetter daniel at ffwll.ch
Wed Jun 8 14:34:28 UTC 2016


On Wed, Jun 08, 2016 at 03:24:01PM +0100, Chris Wilson wrote:
> On Wed, Jun 08, 2016 at 02:19:08PM +0200, Daniel Vetter wrote:
> > Note that I didn't start garbage collecting all the legacy flip code
> > yet, to make it easier to revert this. But there will be _lots_ of
> > code that can be removed once this is tested on all platforms.
> > 
> > FIXME: obj->frontbuffer_bits gets out of whack when pipelining
> > commits too hard.
> 
> Possible to write a test case using dumb kms, or just point me at one
> you have already? :)

Argh, that FIXME is addressed by the next patch. Forgot to reorder them
and drop the FIXME here. The rmfb worker vs. flips was enough concurrency
to hit this bug.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch


More information about the dri-devel mailing list