[PATCH] drm/omapdrm: don't call drm_helper_disable_unused_functions

Laurent Pinchart laurent.pinchart at ideasonboard.com
Thu Jun 9 22:50:00 UTC 2016


Hi Daniel,

Thank you for the patch.

On Friday 10 Jun 2016 00:14:39 Daniel Vetter wrote:
> It's a legacy helper function which won't do good with atomic helpers.
> 
> Cc: Tomi Valkeinen <tomi.valkeinen at ti.com>
> Cc: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> Signed-off-by: Daniel Vetter <daniel.vetter at intel.com>

Acked-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  drivers/gpu/drm/omapdrm/omap_fbdev.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/omapdrm/omap_fbdev.c
> b/drivers/gpu/drm/omapdrm/omap_fbdev.c index 31dfa0893416..adb10fbe918d
> 100644
> --- a/drivers/gpu/drm/omapdrm/omap_fbdev.c
> +++ b/drivers/gpu/drm/omapdrm/omap_fbdev.c
> @@ -279,9 +279,6 @@ struct drm_fb_helper *omap_fbdev_init(struct drm_device
> *dev) if (ret)
>  		goto fini;
> 
> -	/* disable all the possible outputs/crtcs before entering KMS mode */
> -	drm_helper_disable_unused_functions(dev);
> -
>  	ret = drm_fb_helper_initial_config(helper, 32);
>  	if (ret)
>  		goto fini;

-- 
Regards,

Laurent Pinchart



More information about the dri-devel mailing list