[PATCH] drm/exynos: use logical AND in exynos_drm_plane_check_size()

Eric Engestrom eric.engestrom at imgtec.com
Fri Jun 10 10:54:50 UTC 2016


On Wed, May 25, 2016 at 02:30:07PM +0200, Tobias Jakobi wrote:
> The current bitwise AND should result in the same assembler
> but this is what the code is actually supposed to do.
> 
> Signed-off-by: Tobias Jakobi <tjakobi at math.uni-bielefeld.de>

Reviewed-by: Eric Engestrom <eric.engestrom at imgtec.com>

> ---
>  drivers/gpu/drm/exynos/exynos_drm_plane.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_plane.c b/drivers/gpu/drm/exynos/exynos_drm_plane.c
> index b3f3c2c..e4a1a63 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_plane.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_plane.c
> @@ -226,7 +226,7 @@ exynos_drm_plane_check_size(const struct exynos_drm_plane_config *config,
>  	    state->v_ratio == (1 << 15))
>  		height_ok = true;
>  
> -	if (width_ok & height_ok)
> +	if (width_ok && height_ok)
>  		return 0;
>  
>  	DRM_DEBUG_KMS("scaling mode is not supported");
> -- 
> 2.7.3


More information about the dri-devel mailing list