[PATCH v2 6/6] drm/panel: simple: Add support for Sharp LQ123P1JX31 2400x1600 panel

Yakir Yang ykk at rock-chips.com
Sun Jun 12 02:12:20 UTC 2016


Doug,

On 06/11/2016 12:11 AM, Doug Anderson wrote:
> Hi,
>
> On Wed, Jun 8, 2016 at 9:35 AM, Doug Anderson <dianders at chromium.org> wrote:
>> Yakir,
>>
>> On Wed, Jun 8, 2016 at 4:52 AM, Yakir Yang <ykk at rock-chips.com> wrote:
>>> The Sharp LQ123P1JX31 is an 12.3", 2400x1600 TFT-LCD panel connected
>>> using eDP interfaces.
>>>
>>> Signed-off-by: Yakir Yang <ykk at rock-chips.com>
>>> ---
>>> Changes in v2:
>>> - Add detail timing of Sharp LQ123P1JX31 panel in v2
>>>
>>>   drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++++++++++++++
>>>   1 file changed, 26 insertions(+)
>> Looks good to me.  Values in the table match the EDID I see from this
>> panel and everything else looks to be in order.
>>
>> Reviewed-by: Doug Anderson <dianders at chromium.org>
>> Tested-by: Doug Anderson <dianders at chromium.org>
> Sorry for not noticing.  :(  ...but as others have pointed out for
> your earlier patches, the size is incorrect.  I found the correct size
> and it should be:
>
>                 .width = 259,
>                 .height = 173,
>

Ah, thanks, would correct it now :-D

- Yakir

> -Doug
>
>
>




More information about the dri-devel mailing list