[PATCH] drm/virtio: Don't reinvent a flipping wheel

Gerd Hoffmann kraxel at redhat.com
Mon Jun 13 09:20:29 UTC 2016


On Fr, 2016-06-10 at 17:20 +0200, Daniel Vetter wrote:
> On Fri, Jun 10, 2016 at 12:07:53AM +0200, Daniel Vetter wrote:
> > Now that the core helpers support nonblocking atomic commits there's
> > no need to invent that wheel separately (instead of fixing the bug in
> > the atomic implementation of virtio, as it should have been done!).
> > 
> > v2: Rebased on top of
> > 
> > commit e7cf0963f816fa44190caaf51aeffaa614c340c6
> > Author: Gerd Hoffmann <kraxel at redhat.com>
> > Date:   Tue May 31 08:50:47 2016 +0200
> > 
> > virtio-gpu: add atomic_commit function
> > 
> > Cc: Gerd Hoffmann <kraxel at redhat.com>
> > Tested-by: Gerd Hoffmann <kraxel at redhat.com> (v1)
> > Reviewed-by: Gerd Hoffmann <kraxel at redhat.com> (v1)
> > Signed-off-by: Daniel Vetter <daniel.vetter at intel.com>
> 
> Gerd, can you pls retest? I think due to your change in the above
> referenced commit to switch to active_only=true in commit_planes() this is
> now broken.

Yes, probably it'll break things.

Any branch I can test?  Your "stuff" branch seems to not yet have the
commit above.

I guess virtio-gpu should switch over to override .atomic_commit_tail
instead of .atomic_commit?

cheers,
  Gerd



More information about the dri-devel mailing list