[PATCH v2 1/2] dt-bindings: add Starry KR122EA0SRA panel binding

[Thierry Reding]

On Fri, Jun 10, 2016 at 12:52:41PM -0700, Doug Anderson wrote:
> Rob,
> 
> On Fri, Jun 10, 2016 at 11:43 AM, Rob Clark <robdclark at gmail.com> wrote:
> > On Fri, Jun 10, 2016 at 1:02 PM, Douglas Anderson <dianders at chromium.org> wrote:
> >> The Starry KR122EA0SRA is a 12.2", 1920x1200 TFT-LCD panel connected
> >> using eDP interfaces.
> >
> > so drive-by comment... but shouldn't eDP be probe-able?  Not sure why
> > we need panel drivers or DT bindings?
> 
> I was wondering about that too.  As far as I can tell:
> 
> 1. We need a panel driver because that appears to be what owns a
> reference to the backlight / panel power regulator and that part is
> not auto-probable.

Yes, that's one of the reasons why we still need DT nodes for panels,
even on a probe-able bus.

eDP has a mechanism to allow brightness control via DPCD, but I've never
actually seen it implemented. Even if we had that, we'd likely need to
represent supplies and GPIOs for the backlight, and we'd be back to
square one.

DSI also provides a means to control backlight brightness, but in the
same way that eDP doesn't go all the way, we'd require external
resources to be hooked up via DT again.

> 2. As far as I could tell, there is no way to declare a generic
> (unspecified) panel in the device tree.  Everyone seems to include
> "simple-panel" in their compatible string but as far as I can tell
> nothing in the kernel looks at it.

The ones that do are wrong and should eventually be updated. This was
originally done, and the driver used to match on simple-panel as well,
but in retrospect that didn't make any sense at all so it was removed
from the driver again.

One of the reasons why it doesn't make any sense is because even if you
have an EDID that's reachable, the EDID itself doesn't fully specify the
panel. Power sequences are one example of data that's not represented in
EDID.

> 3. In theory, all the info specified here should match the EDID
> exactly and thus (as you said) be probable.  However, it sounds like
> (for power sequencing reasons) there might be reasons why you'd want
> to know exactly what panel was present beforehand.  You might need to
> power the panel and backlight in very specific sequences, for
> instance.  I'm not sure it's always 100% possible in all embedded
> designs to read the EDID before you know how the sequencing should
> work (but, of course, I'm a NOOB).

It doesn't really matter whether you can access EDID or not, because
EDID contains absolutely nothing on the power sequences for the panel.
Even if it did, there'd be no way to relate that information to the
device tree binding phandles.

> 4. Reading the EDID can be slow.  If you happen to know all the info
> on the panel beforehand you can significantly speed up boot speed,
> notably how fast you can get something on the screen.

The motivation for potentially duplicating this information was not that
it's slow to read EDID, but that occasionally you might not be able to
access EDID. There could be a number of reasons why this might happen: a
device might end up with an erased or invalid EDID or the DDC used to
get at the EDID might be broken (I've been told that it's fairly common
for OEMs to not wire through the DDC wires in cables to reduce costs).

Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20160613/9e49e0f3/attachment.sig>