[Intel-gfx] [PATCH 08/14] drm: Move authmagic cleanup into drm_master_release

Chris Wilson chris at chris-wilson.co.uk
Wed Jun 15 11:51:14 UTC 2016


On Tue, Jun 14, 2016 at 08:51:03PM +0200, Daniel Vetter wrote:
> It's related, and soon authmagic will also use the master_mutex.
> 
> There is an ever-so-slightly semantic change here:
> - authmagic will only be cleaned up for primary_client drm_minors. But
>   it's impossible to create authmagic on render/control nodes, so this
>   is fine.

For reference: file_priv->magic is created by the drm_getmagic() ioctl,
only available on the legacy device node.

> - The cleanup is moved down a bit in the release processing. Doesn't
>   matter at all since authmagic is purely internal logic used by the
>   core ioctl access checks, and when we're in a file's release
>   callback no one can do ioctls any more.
> 
> Signed-off-by: Daniel Vetter <daniel.vetter at intel.com>
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the dri-devel mailing list