[Intel-gfx] [PATCH 02/14] drm: Hide hw.lock cleanup in filp->release better

Emil Velikov emil.l.velikov at gmail.com
Wed Jun 15 12:10:31 UTC 2016


On 14 June 2016 at 19:50, Daniel Vetter <daniel.vetter at ffwll.ch> wrote:
> A few things:
> - Rename the cleanup function from drm_master_release to
>   drm_legacy_lock_release. It doesn't relase any master stuff, but
>   just the legacy hw lock.
> - Hide it in drm_lock.c, which allows us to make a few more functions
>   static in there. To avoid forward decl we need to shuffle the code a
>   bit though.
> - Push the check for ->master into the function itself.
> - Only call this for !DRIVER_MODESET.
>
As per the multiple points above - it would have been great to split
out the drm_lock.c code reshuffle as separate patch.
Regardless of my suggestion:
Reviewed-by: Emil Velikov <emil.l.velikov at gmail.com>

Side note: I think we don't need/bother with kernel doc for static
functions, do we ?

-Emil


More information about the dri-devel mailing list